Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tui dep to ratatui #53

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Conversation

dan-da
Copy link
Collaborator

@dan-da dan-da commented Sep 24, 2023

Addresses #52

Cargo.toml:

  • removes tui dep
  • adds ratatui 0.20.0 dep

Also updates dashboard src files to use ratatui instead of tui.

Testing:

Ran neptune-dashboard and verified that all screen/tabs load and appear to look correct.

Notes:

  • tui is unmaintained.
  • ratatui v0.20.0 appears to be drop-in replacement for tui 0.19.0. It builds and runs without error.
  • ratatui v.0.21.0 and above deprecate some things and do not compile cleanly for the dashboard, so minor work will be required should we wish to use a later version. For now though I prefer to keep the PR small so its easier to review.
  • I opted to change tui references in code rather than aliasing ratatui to tui in Cargo.toml.

Addresses Neptune-Crypto#52

Cargo.toml:

* removes tui dep
* adds ratatui 0.20.0 dep

Also updates dashboard src files to use ratatui instead of tui.
@Sword-Smith Sword-Smith self-requested a review September 25, 2023 12:30
@Sword-Smith Sword-Smith merged commit 6db39fa into Neptune-Crypto:master Sep 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants