Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split resync membership proofs #186

Closed
wants to merge 1 commit into from

Conversation

dan-da
Copy link
Collaborator

@dan-da dan-da commented Sep 17, 2024

addresses #183.

The comment for GlobalStateLock::resync_membership_proofs() explains:

    /// This fn performs potentially lengthy operations.  The work has been
    /// split into two: an immutable fn that prepares a batch of updates and a
    /// mutable fn that finalizes (writes) the updates as quickly as possible.
    /// In this way, we do not hold the write-lock any longer than necessary.
    ///
    /// Splitting the logic this way requires buffering updates in RAM.  We batch
    /// the updates to avoid running out of mem.  The batch size is initially
    /// set to 1000.  This is just a wild-ass-guess.  It seems high enough that
    /// most wallets will only need a single batch, but low enough that we
    /// shouldn't run out of mem if processing a huge wallet.

@dan-da
Copy link
Collaborator Author

dan-da commented Sep 23, 2024

closing in favor of #187.

@dan-da dan-da closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant