completions should work when server not running

In neptune-cli:

  * process completions command before connecting to server.

In install-bash-completions.sh:

  * modify error handling so error on any line will abort script.

scripts/install-bash-completions.sh

@@ -1,9 +1,11 @@
+set -e
+
 SCRIPT="$HOME/.bash_neptune_cli"
 LINE="source $SCRIPT"
 FILE="$HOME/.bashrc"
 
-cargo run --bin neptune-cli -- completions > $SCRIPT && \
-grep -qF -- "$LINE" "$FILE" || echo "$LINE" >> "$FILE" && \
-source $SCRIPT && \
+cargo run --bin neptune-cli -- completions > $SCRIPT
+grep -qF -- "$LINE" "$FILE" || echo "$LINE" >> "$FILE"
+source $SCRIPT
 echo "completions installed to $SCRIPT and added to $FILE"
 

src/bin/neptune-cli.rs

@@ -64,6 +64,17 @@ struct Config {
 #[tokio::main]
 async fn main() -> Result<()> {
     let args: Config = Config::parse();
+
+    // Check for completions command before establishing server connection.
+    if let Command::Completions = args.command {
+        if let Some(shell) = Shell::from_env() {
+            generate(shell, &mut Config::command(), "neptune-cli", &mut stdout());
+            return Ok(());
+        } else {
+            bail!("Unknown shell.  Shell completions not available.")
+        }
+    }
+
     let transport = tarpc::serde_transport::tcp::connect(args.server_addr, Json::default);
     let client = RPCClient::new(client::Config::default(), transport.await?).spawn();
 
@@ -164,13 +175,7 @@ async fn main() -> Result<()> {
             println!("{prunt_res_count} monitored UTXOs marked as abandoned");
         }
 
-        Command::Completions => {
-            if let Some(shell) = Shell::from_env() {
-                generate(shell, &mut Config::command(), "neptune-cli", &mut stdout());
-            } else {
-                bail!("Unknown shell.  Shell completions not available.")
-            }
-        }
+        Command::Completions => {} // handled before server connection.
     }
 
     Ok(())