Test github actions #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rkusa action issue: rkusa/eslint-action#2 None of the annotators work ATM..maybe same issue as Azure Pipelines has.. 🤞 |
|
Also this PR needs to re-implement slack notify (if we still want it?). |
JockeCK
reviewed
Sep 3, 2019
added 14 commits
September 10, 2019 21:01
Use npm install until we have package-lock
Unable to re-trigger build ?
nomego
force-pushed
the
github-actions
branch
from
8de94fc to
b56e9fb
Compare
nomego
force-pushed
the
github-actions
branch
from
b56e9fb to
6048487
Compare
nomego
force-pushed
the
github-actions
branch
from
d14b130 to
ebf9cc2
Compare
added 3 commits
September 11, 2019 06:47
Signed-off-by: Patrik Kullman <[email protected]> Signed-off-by: Patrik Kullman <[email protected]>
nomego
force-pushed
the
github-actions
branch
from
df18e55 to
800a145
Compare
added 4 commits
September 11, 2019 10:12
Signed-off-by: Patrik Kullman <[email protected]>
Signed-off-by: Patrik Kullman <[email protected]>
Signed-off-by: Patrik Kullman <[email protected]>
Signed-off-by: Patrik Kullman <[email protected]>
|
Example of annotation with our annotator (https://github.com/Neovici/github-actions-eslint-annotator, info will be adjusted there) ESLint step will create its own check so it won't fail on eslint errors, rather if the check itself fails. Slack build completion notify is not ported from Travis, we'll start without it to see if we miss it. Will commit away the error, then ready for actual review (SHOULD BE SQUASHED!) |
Signed-off-by: Patrik Kullman <[email protected]>
nomego
requested review from
JockeCK and
a team
and removed request for
cristinecula
Wurper
approved these changes
Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.