Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ovos core dependency #451

Merged
merged 7 commits into from
Jul 10, 2023
Merged

Remove ovos core dependency #451

merged 7 commits into from
Jul 10, 2023

Conversation

NeonDaniel
Copy link
Member

@NeonDaniel NeonDaniel commented May 19, 2023

Description

Refactor package to import from ovos-workshop and ovos-utils to remove mycrfot imports

Issues

Relates to #469

Other Notes

ovos-core is still listed as a test dependency as some tests are failing without it. Failures appear to be related to configuration handling, but are not immediately resolvable so this will be left to a future PR, possibly after some of the configuration marked for deprecation is actually deprecated

@mikejgray
Copy link
Contributor

Found a few more doing some testing:

neon_utils.validator_utils:

# from mycroft.skills.core import MycroftSkill
from ovos_workshop.skills.mycroft_skill import MycroftSkill

neon_utils.skills.common_play_skill:

# from mycroft.skills.audioservice import AudioService
from ovos_utils.skills.audioservice import OCPInterface as AudioService

neon_utils.skills.skill_gui:

# from mycroft.enclosure.gui import SkillGUI as _SkillGUI
from ovos_workshop.skills.base import SkillGUI as _SkillGUI

@NeonDaniel NeonDaniel force-pushed the FEAT_RemoveOvosCoreDependency branch from 1e58e04 to 8947253 Compare July 10, 2023 17:35
@NeonDaniel NeonDaniel marked this pull request as ready for review July 10, 2023 17:35
@NeonDaniel NeonDaniel force-pushed the FEAT_RemoveOvosCoreDependency branch from 28b9375 to a578486 Compare July 10, 2023 18:24
@NeonDaniel NeonDaniel merged commit 669d0ff into dev Jul 10, 2023
@NeonDaniel NeonDaniel deleted the FEAT_RemoveOvosCoreDependency branch July 10, 2023 18:55
@github-actions github-actions bot mentioned this pull request Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants