Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python version and dependencies #65

Merged
merged 8 commits into from
Jan 14, 2025
Merged

Conversation

NeonDaniel
Copy link
Member

@NeonDaniel NeonDaniel commented Jan 10, 2025

Description

Updates Dockerfile to use Python3.10
Updates ovos-bus-client dependency to allow 0.1+
Adds missing ovos-config dependency which was previously just inherited from other dependencies

Issues

Closes #62
Needs NeonGeckoCom/neon_mq_connector#110 to resolve test cleanup errors

Other Notes

@NeonDaniel NeonDaniel requested a review from mikejgray January 10, 2025 20:03
@NeonDaniel
Copy link
Member Author

Rebase on #64 to resolve test failures

Copy link
Contributor

@mikejgray mikejgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good code-wise, I'll test this container in my Hub instance to see if it resolves the issue we were talking about

Updates ovos-bus-client dependency to allow 0.1+
Adds missing ovos-config dependency which was previously just inherited from other dependencies
@NeonDaniel NeonDaniel force-pushed the FEAT_UpdateDependencies branch from 7da3428 to 3f4e5d1 Compare January 13, 2025 23:25
@NeonDaniel NeonDaniel marked this pull request as ready for review January 13, 2025 23:29
@NeonDaniel
Copy link
Member Author

I built an alpha Gradio container and tested to validate this all works. These dependency updates are required for #63

Refactor shutdown to ensure MQ client connections are closed
@NeonDaniel NeonDaniel requested a review from mikejgray January 14, 2025 02:03
@NeonDaniel NeonDaniel marked this pull request as draft January 14, 2025 02:03
@NeonDaniel NeonDaniel marked this pull request as ready for review January 14, 2025 17:26
@NeonDaniel NeonDaniel merged commit 34d7e4a into dev Jan 14, 2025
7 checks passed
@NeonDaniel NeonDaniel deleted the FEAT_UpdateDependencies branch January 14, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Upgrade Python version in Docker
2 participants