-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Python version and dependencies #65
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebase on #64 to resolve test failures |
mikejgray
reviewed
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good code-wise, I'll test this container in my Hub instance to see if it resolves the issue we were talking about
mikejgray
approved these changes
Jan 11, 2025
Updates ovos-bus-client dependency to allow 0.1+ Adds missing ovos-config dependency which was previously just inherited from other dependencies
…OS_DEFAULT_CONFIG` envvar
NeonDaniel
force-pushed
the
FEAT_UpdateDependencies
branch
from
January 13, 2025 23:25
7da3428
to
3f4e5d1
Compare
I built an alpha Gradio container and tested to validate this all works. These dependency updates are required for #63 |
Refactor shutdown to ensure MQ client connections are closed
…nitely Add unit test timeout to prevent running forever
Refactor to implement `shutdown` method from neon-mq-connector changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates Dockerfile to use Python3.10
Updates ovos-bus-client dependency to allow 0.1+
Adds missing ovos-config dependency which was previously just inherited from other dependencies
Issues
Closes #62
Needs NeonGeckoCom/neon_mq_connector#110 to resolve test cleanup errors
Other Notes