Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc changes #1878

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Misc changes #1878

wants to merge 4 commits into from

Conversation

fingolfin
Copy link
Member

  • Remove redundant gcdinv methods
  • Add isapprox methods for ZZRingElem & QQFieldElem
  • Enhance fpPolyRingElem constructor to accept more Integer types
  • Fix missing return values in two unsafe ops

The default method in AA delegates to gcdx
... to allow testing relative and absolute series
... e.g. Bool -- this is needed to pass the conformance tests
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 87.23%. Comparing base (d457d82) to head (b7eb26a).

Files with missing lines Patch % Lines
src/flint/fmpq.jl 0.00% 4 Missing ⚠️
src/flint/fmpz.jl 0.00% 4 Missing ⚠️
src/HeckeMoreStuff.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1878      +/-   ##
==========================================
- Coverage   87.29%   87.23%   -0.06%     
==========================================
  Files          97       97              
  Lines       35745    35727      -18     
==========================================
- Hits        31202    31166      -36     
- Misses       4543     4561      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant