Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More generic test_elem methods #1827

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

More generic test_elem methods #1827

wants to merge 1 commit into from

Conversation

fingolfin
Copy link
Member

Also make sure other packages which only load Rings-conformance-tests.jl
get them.

Finally cleanup how we include Groups-conformance-tests.jl

Unfortunately this causes test failures and eventually a bus error crash (!). This is due to the test_elem(Rx::AbstractAlgebra.SeriesRing) method. The crash can be triggered with

R, x = power_series_ring(ZZ, 10, :x)
include("test/Rings-conformance-tests.jl");
test_Ring_interface(R)

Note that there are failures before that because the tests for the unsafe ops add! etc. don't take into account that the series rings are inexact. I hope #1816 will fix that part.

But even taking that into account, we really shouldn't get a hard crash here

Also make sure other packages which only load Rings-conformance-tests.jl
get them.

Finally cleanup how we include Groups-conformance-tests.jl
@fingolfin
Copy link
Member Author

@joschmitt figured out the cause for the crash (to be fixed by PR #1828), which in turn was triggered by the coefficients lists for the series starting with a zero.

The failures in the unsafe ops tests are still there, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant