Move assertions.jl from Hecke
#1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thofma
approved these changes
Sep 17, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1789 +/- ##
==========================================
- Coverage 88.01% 87.96% -0.06%
==========================================
Files 118 119 +1
Lines 30074 30114 +40
==========================================
+ Hits 26470 26490 +20
- Misses 3604 3624 +20 ☔ View full report in Codecov by Sentry. |
lgoettgens
force-pushed
the
lg/assertions
branch
2 times, most recently
from
fff8d2e
to
6b0762c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
lgoettgens
commented
Sep 17, 2024
lgoettgens
force-pushed
the
lg/assertions
branch
from
378efdd
to
8cf42a7
Compare
|
@thofma @fingolfin can someone of you force-merge this? Due to the version bump in #1792, all of the downstream CI is useless, but github complains because there is a same-named branch in Hecke (and thus the wrong downstream CI tests run and do nothing). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thofma/Hecke.jl#1607 is the corresponding cleanup.