Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul mutating arithmetics #1784

Merged
merged 18 commits into from
Sep 16, 2024
Merged

Conversation

lgoettgens
Copy link
Collaborator

@lgoettgens lgoettgens commented Sep 16, 2024

Inspired by Nemocas/Nemo.jl#1811 (comment).
Resolves #1736.

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 27 lines in your changes missing coverage. Please review.

Project coverage is 87.99%. Comparing base (cfdcd27) to head (06d4524).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/fundamental_interface.jl 48.27% 15 Missing ⚠️
src/Matrix.jl 84.21% 6 Missing ⚠️
src/AbsSeries.jl 83.33% 1 Missing ⚠️
src/NCPoly.jl 66.66% 1 Missing ⚠️
src/Poly.jl 92.85% 1 Missing ⚠️
src/RelSeries.jl 85.71% 1 Missing ⚠️
src/generic/MPoly.jl 91.66% 1 Missing ⚠️
src/julia/Rational.jl 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1784      +/-   ##
==========================================
- Coverage   88.04%   87.99%   -0.05%     
==========================================
  Files         117      117              
  Lines       30102    30037      -65     
==========================================
- Hits        26503    26432      -71     
- Misses       3599     3605       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lgoettgens lgoettgens force-pushed the lg/unsafe-arith branch 3 times, most recently from ea75b26 to 21d76c1 Compare September 16, 2024 12:54
@lgoettgens lgoettgens marked this pull request as ready for review September 16, 2024 13:38
@thofma
Copy link
Member

thofma commented Sep 16, 2024

can you add a gcd!(a, b, c) = gcd(b, c)?

@lgoettgens lgoettgens enabled auto-merge (squash) September 16, 2024 15:41
@lgoettgens lgoettgens merged commit 86996ee into Nemocas:master Sep 16, 2024
28 of 30 checks passed
@lgoettgens lgoettgens deleted the lg/unsafe-arith branch September 16, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why is addeq! not just called add! ?
2 participants