Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the mess I created when I cleaned up NemoStuff.jl #1780

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

joschmitt
Copy link
Collaborator

@joschmitt joschmitt commented Aug 28, 2024

In #1769, I removed mulmod(::T, ::T, ::Vector{T}) where T <: MPolyRingElem; apparently this is used in Hecke though. (I was certain I ran all the tests locally, but apparently I missed the "long" ones?)

I don't like the name of this function (mod in the context of several multivariate polynomials sounds like Gröbner stuff to me?) and in the end writing divrem(a * b, m)[2] is not much longer.
So, I would only want to introduce this as a deprecation. Is that fine?

Sorry for this.

NEW: I put mulmod in Deprecations.jl but only as a redirect. I also removed another deprecation introduced in #1769 which is actually used in Hecke.

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.03%. Comparing base (8d1047a) to head (2d77278).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/Deprecations.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1780      +/-   ##
==========================================
- Coverage   88.04%   88.03%   -0.01%     
==========================================
  Files         117      117              
  Lines       30092    30094       +2     
==========================================
  Hits        26494    26494              
- Misses       3598     3600       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joschmitt joschmitt changed the title Reintroduce mulmod(::T, ::T, ::Vector{T}) Clean up the mess I created when I cleaned up NemoStuff.jl Aug 29, 2024
@joschmitt
Copy link
Collaborator Author

The Hecke long tests (with GAP and Polymake and depwarn=error) passed locally, so I hope that this is fine now.

@thofma thofma enabled auto-merge (squash) August 29, 2024 08:41
@thofma thofma merged commit 75a8537 into Nemocas:master Aug 29, 2024
29 of 30 checks passed
@joschmitt joschmitt deleted the js/mulmod branch August 29, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants