Clean up the mess I created when I cleaned up NemoStuff.jl
#1780
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1769, I removed
mulmod(::T, ::T, ::Vector{T}) where T <: MPolyRingElem
; apparently this is used in Hecke though. (I was certain I ran all the tests locally, but apparently I missed the "long" ones?)I don't like the name of this function (
mod
in the context of several multivariate polynomials sounds like Gröbner stuff to me?) and in the end writingdivrem(a * b, m)[2]
is not much longer.So, I would only want to introduce this as a deprecation. Is that fine?
Sorry for this.
NEW: I put
mulmod
inDeprecations.jl
but only as a redirect. I also removed another deprecation introduced in #1769 which is actually used in Hecke.