Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Groups of order > 2^15 in conformance test #1600

Merged
merged 1 commit into from
Feb 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions test/Groups-conformance-tests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,13 @@ function test_Group_interface(G::Group)

@testset "order, rand" begin
if is_finite(G)
@test order(Int16, G) isa Int16
@test order(BigInt, G) isa BigInt
ord = order(BigInt, G)
@test ord isa BigInt
if ord < typemax(Int16)
@test order(Int16, G) isa Int16
else
@test_throws InexactError order(Int16, G)
end
@test order(G) >= 1
@test is_trivial(G) == (order(G) == 1)
else
Expand Down
2 changes: 1 addition & 1 deletion test/generic/PermGroupAPI-test.jl
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
@testset "GroupsCore API PermGroup" begin

include(joinpath(dirname(dirname(pathof(AbstractAlgebra))), "test", "Groups-conformance-tests.jl"))
@testset "Sym($n)" for n in [1,2,5]
@testset "Sym($n)" for n in [1,2,5,10]
G = SymmetricGroup(n)
test_Group_interface(G)
test_GroupElem_interface(rand(G, 2)...)
Expand Down
Loading