Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix generalized indexing #1585

Merged
merged 1 commit into from
Feb 12, 2024
Merged

feat: fix generalized indexing #1585

merged 1 commit into from
Feb 12, 2024

Conversation

thofma
Copy link
Member

@thofma thofma commented Jan 29, 2024

  • make A[i::Int, js::Array] return a Vector and support views

@thofma
Copy link
Member Author

thofma commented Jan 29, 2024

Split off from #1565, since it is easier this way.

@thofma
Copy link
Member Author

thofma commented Jan 29, 2024

This is breaking, but I want to add it in this 0.37.* round. Or maybe not.

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (14b8c2b) 87.17% compared to head (cb43fd5) 86.93%.
Report is 9 commits behind head on master.

Files Patch % Lines
src/Matrix.jl 15.78% 16 Missing ⚠️
src/generic/Matrix.jl 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1585      +/-   ##
==========================================
- Coverage   87.17%   86.93%   -0.24%     
==========================================
  Files         115      115              
  Lines       29565    30075     +510     
==========================================
+ Hits        25773    26147     +374     
- Misses       3792     3928     +136     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thofma thofma marked this pull request as draft January 29, 2024 22:41
@thofma thofma marked this pull request as ready for review January 30, 2024 07:33
@lgoettgens
Copy link
Collaborator

This is breaking, but I want to add it in this 0.37.* round. Or maybe not.

If this is breaking, we cannot include it in 0.37.2. Instead, this has to wait for 0.38.0

@thofma
Copy link
Member Author

thofma commented Jan 30, 2024

Yeah, 0.38.0 it is

@thofma thofma closed this Feb 1, 2024
@thofma thofma reopened this Feb 1, 2024
- make A[i::Int, js::Array] return a Vector and support views
@thofma thofma closed this Feb 2, 2024
@thofma thofma reopened this Feb 2, 2024
@thofma thofma closed this Feb 2, 2024
@thofma thofma reopened this Feb 2, 2024
@thofma thofma closed this Feb 10, 2024
@thofma thofma reopened this Feb 10, 2024
@thofma thofma closed this Feb 10, 2024
@thofma thofma reopened this Feb 10, 2024
@thofma thofma merged commit cf05e04 into master Feb 12, 2024
88 of 97 checks passed
@thofma thofma deleted the th/index branch February 12, 2024 09:35
ooinaruhugh pushed a commit to ooinaruhugh/AbstractAlgebra.jl that referenced this pull request Feb 15, 2024
- make A[i::Int, js::Array] return a Vector and support views
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants