Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw an error in case of division by zero instead of crashing hard #1828

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

joschmitt
Copy link
Collaborator

Apparently, __gmpz_divexact crashes in case of a division by 0. I would say that we should throw an error even if check = false.

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.04%. Comparing base (6be27f6) to head (8c639eb).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1828   +/-   ##
=======================================
  Coverage   88.03%   88.04%           
=======================================
  Files         119      119           
  Lines       29982    29985    +3     
=======================================
+ Hits        26396    26400    +4     
+ Misses       3586     3585    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fingolfin fingolfin enabled auto-merge (squash) October 4, 2024 09:54
@fingolfin fingolfin merged commit 0fcc4cd into master Oct 4, 2024
29 of 30 checks passed
@fingolfin fingolfin deleted the js/divby0 branch October 4, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants