Move methods from AA.* to Base.*

the `AA.*` should only implement methods for julia types and delegate everything else
Nemocas · Oct 2, 2024 · d7eb617 · d7eb617
1 parent a17088e
commit d7eb617
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 12 deletions.
diff --git a/src/Fields.jl b/src/Fields.jl
@@ -16,7 +16,7 @@ is_zero_divisor(a::T) where T <: FieldElem = is_zero(a)
 
 Base.divrem(a::T, b::T) where {T <: FieldElem} = divexact(a, b), zero(parent(a))
 
-div(a::T, b::T) where {T <: FieldElem} = divexact(a, b)
+Base.div(a::T, b::T) where {T <: FieldElem} = divexact(a, b)
 
 function gcd(x::T, y::T) where {T <: FieldElem}
    check_parent(x, y)

diff --git a/src/Poly.jl b/src/Poly.jl
@@ -1479,11 +1479,6 @@ function Base.divrem(f::PolyRingElem{T}, g::PolyRingElem{T}) where T <: RingElem
    return q, f
 end
 
-function Base.div(f::PolyRingElem{T}, g::PolyRingElem{T}) where T <: RingElement
-   q, r = divrem(f, g)
-   return q
-end
-
 ##############################################################################
 #
 #  Ad hoc Euclidean division

diff --git a/src/generic/LaurentMPoly.jl b/src/generic/LaurentMPoly.jl
@@ -106,7 +106,7 @@ function is_gen(a::LaurentMPolyWrap)
     return !iszero(_var_index(a))
 end
 
-function inv(a::LaurentMPolyWrap)
+function Base.inv(a::LaurentMPolyWrap)
     (ap, ad) = _normalize(a)
     return LaurentMPolyWrap(parent(a), inv(ap), neg!(ad, ad))
 end
@@ -204,7 +204,7 @@ function gcd(a::LaurentMPolyWrap, b::LaurentMPolyWrap)
     return LaurentMPolyWrap(parent(a), gcd(ap, bp), zero!(ad))
 end
 
-function divrem(a::LaurentMPolyWrap, b::LaurentMPolyWrap)
+function Base.divrem(a::LaurentMPolyWrap, b::LaurentMPolyWrap)
     check_parent(a, b)
     error("divrem not implemented for LaurentMPoly")
 end

diff --git a/src/generic/Misc/Localization.jl b/src/generic/Misc/Localization.jl
@@ -263,10 +263,6 @@ function Base.divrem(a::LocalizedEuclideanRingElem{T}, b::LocalizedEuclideanRing
   end
 end
 
-function Base.div(a::LocalizedEuclideanRingElem{T}, b::LocalizedEuclideanRingElem{T}) where {T}
-  return divrem(a, b)[1]
-end
-
 function rem(a::LocalizedEuclideanRingElem{T}, b::LocalizedEuclideanRingElem{T}) where {T}
   return divrem(a, b)[2]
 end