Add comments to bad reduce dispatches

Nemocas · Oct 13, 2023 · 5a51616 · 5a51616
1 parent 09a9541
commit 5a51616
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/src/Matrix.jl b/src/Matrix.jl
@@ -6496,6 +6496,7 @@ function Base.vcat(A::MatrixElem{T}...) where T <: NCRingElement
   return _vcat(A)
 end
 
+# this leads to an ambiguity when calling `reduce(hcat, Union{}[])`, but we don't have a better solution right now
 Base.reduce(::typeof(vcat), A::AbstractVector{<:MatrixElem}) = _vcat(A)
 
 function _vcat(A)
@@ -6534,6 +6535,7 @@ function Base.hcat(A::MatrixElem{T}...) where T <: NCRingElement
   return _hcat(A)
 end
 
+# this leads to an ambiguity when calling `reduce(hcat, Union{}[])`, but we don't have a better solution right now
 Base.reduce(::typeof(hcat), A::AbstractVector{<:MatrixElem}) = _hcat(A)
 
 function _hcat(A)