[WIP] Follow base api 1.0 #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nek-
changed the title
|
|
||
| public function getUrl() | ||
| { | ||
| return 'youtube/v3/videos'; |
There was a problem hiding this comment.
To force a user extending AbstractApi to define theses methods.
He don't have to if they are just consts.
There was a problem hiding this comment.
and with return self::URL; ?
There was a problem hiding this comment.
I don't see the interest of having 2 way to get the information
|
@Nek- How is the PR coming ? |
|
@Shine-neko The problem is that it need I fork guzzle first. guzzle/guzzle#944 (comment) And I'm currently super-buzy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.