PHP8 update - incomplete #161
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an actual error, failing only on PHP8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some fixes for a PHP 8 update.
By testing it against the test suite of autobahn, it appears that this is not sufficient to make Woketo fully compatible with PHP 8.
Some problems may be related to the React dependency (it seems that it buffer overflows in big amount of data, something like that...).
Fixing everything for PHP 8 may be demanding in term of time, for a project barely nobody uses.
It was very interesting to build it. Pushing it to be a complete thing working for all situations. I even did a project inside a docker with behat tests and all of this was working great. But it seems to be old times. I guess it's goodbye. You may see some PR from me on another project I believe in.