Improved gpio handling for buttons and status LEDs #230
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
|
@MuratUrsavas in hm-pyhelper would we put: Or is either ok? |
|
@shawaj We have to leave them out as otherwise it would return something (False), and it would break current code and give exceptions. It depends on missing keys. |
Ok perfect. So we just leave them out of pyhelper if no button or LED. Nice 👍 |
|
I'll put a note on that repo to update the readme to reflect that NebraLtd/hm-pyhelper#211 |
| self.user_button.start() | ||
| self.status_led = MraaLED(self.get_status_led_pin()) | ||
| btn = self.get_button_pin() | ||
| if btn is not None: |
There was a problem hiding this comment.
if btn:
would have been the same.
- improved styling to match dashboard on diagnostics NebraLtd/hm-diag#471 - config improved gpio handling NebraLtd/hm-config#230 - bump all containers and versions
Issue
#172
How
If a user button or status led definition is missing in a variant definition, that part of the code is passed gracefully now.
Checklist