Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset password or start bluetooth depending on state on button press #225

Merged
merged 1 commit into from
Jan 8, 2023
Merged

Reset password or start bluetooth depending on state on button press #225

merged 1 commit into from
Jan 8, 2023

Conversation

robputt
Copy link
Contributor

@robputt robputt commented Jan 8, 2023

No description provided.

@robputt robputt requested a review from a team as a code owner January 8, 2023 11:12
@robputt robputt mentioned this pull request Jan 8, 2023
Merged
@robputt
Copy link
Contributor Author

robputt commented Jan 8, 2023

To be merged and deployed with NebraLtd/hm-diag#441

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@shawaj
Copy link
Member

shawaj commented Jan 8, 2023

We probably need to fix #172 at the same time. Separate PR maybe but should be pretty simple I guess:

hm-config/gatewayconfig/gatewayconfig_app.py

Lines 149 to 159 in c580b10

def get_button_gpio(self):
return self.variant_details['BUTTON']
def get_status_led_gpio(self):
return self.variant_details['STATUS']
def get_button_pin(self):
return self.variant_details['GPIO_PIN_BUTTON']
def get_status_led_pin(self):
return self.variant_details['GPIO_PIN_LED']

@shawaj
Copy link
Member

shawaj commented Jan 8, 2023

LGTM

@robputt robputt merged commit f48079c into master Jan 8, 2023
@robputt robputt deleted the FEAT-user-auth branch January 8, 2023 22:41
@shawaj shawaj mentioned this pull request Jan 9, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawaj shawaj shawaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robputt @shawaj