Movie Recommender solved (Bryan) #32
Conversation
|
Please use your global Edit: Also include the |
src/test/java/nearsoft/academy/bigdata/recommendation/MovieRecommenderTest.java
Outdated
Show resolved
Hide resolved
| @@ -24,7 +33,5 @@ public void testDataInfo() throws IOException, TasteException { | |||
| assertThat(recommendations, hasItem("B0002O7Y8U")); | |||
| assertThat(recommendations, hasItem("B00004CQTF")); | |||
| assertThat(recommendations, hasItem("B000063W82")); | |||
|
|
|||
There was a problem hiding this comment.
Is usually a good idea to have just the necessary changes on the PR's, we should try not to include format changes unless is required. Avoiding them makes easier to review the PR's.
There was a problem hiding this comment.
Thanks for the advice! I'll restore the original file with only the necessary changes.
| @@ -12,6 +12,8 @@ | |||
|
|
|||
| <properties> | |||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | |||
| <maven.compiler.source>1.8</maven.compiler.source> | |||
There was a problem hiding this comment.
Why are this changes required? Are they part of the requirements?
There was a problem hiding this comment.
Yeah! I've used maven, which allowed me to create a java project. In order to run, I had to add those dependencies.
You should add a movie.txt.gz file to the
src/datafolder, I tested my code using a provisional filesrc/data/movies_rapid_test.txt.gz