Iván Aguilar - Movie recommendation solution #26
Conversation
| import org.apache.mahout.cf.taste.recommender.UserBasedRecommender; | ||
| import org.apache.mahout.cf.taste.similarity.UserSimilarity; | ||
|
|
||
| import java.io.*; |
There was a problem hiding this comment.
Do you know the disadvantages of using wildcard imports? Why not use only what you need?
There was a problem hiding this comment.
Thank you, I corrected it, I was reading that it could lead to possible name conflicts and the readability of the code would decrease because the developers would not have a clear idea of the actual classes used.
| @@ -15,7 +15,9 @@ | |||
| public void testDataInfo() throws IOException, TasteException { | |||
| //download movies.txt.gz from | |||
| // http://snap.stanford.edu/data/web-Movies.html | |||
| MovieRecommender recommender = new MovieRecommender("/path/to/movies.txt.gz"); | |||
|
|
|||
There was a problem hiding this comment.
You are allowed to change how you read the recommender's data, but you are not allowed to add or make any other changes in the test file. Please remove recommender.convertFileToCSV(); and make sure to make the required changes so that your class still passes all tests.
There was a problem hiding this comment.
Fixed, I removed it from the test file and modified the MovieRecommender, it still passed all the tests.
|
Is there any specific reason why you'd commit and pushed the |
Not really, it was a mistake, I already deleted it |
I finished the exercise, it passed all the tests, the solution reads the txt file and creates a cvs.