fix: Use new version of the connector. #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead use env::predecessor_account_id. Using signer_account_id has the same problems of using tx.origin in Ethereum. See link below for more details: ethereum/solidity#683
Need to use fixed near-sdk-version for compatibility with rainbow-token-connector. This restriction will be lifted once the special commit used by the connector lands on near-sdk-rs.
mfornet
force-pushed
the
update_connector
branch
from
605c2cf
to
e02e307
Compare
mfornet
force-pushed
the
update_connector
branch
from
e02e307
to
92ee49e
Compare
TODO: Don't use current pinned commit from token-connector, instead wait until it is merged into master
mfornet
force-pushed
the
update_connector
branch
from
92ee49e
to
9b3a511
Compare
using new interface
mfornet
force-pushed
the
update_connector
branch
from
dd946fa
to
641ede9
Compare
|
Closes #519 |
alexauroradev
approved these changes
Mar 12, 2021
cli/package.json
Outdated
| @@ -34,7 +34,7 @@ | |||
| "rainbow-bridge-near2eth-block-relay": "1.0.0", | |||
| "rainbow-bridge-watchdog": "1.0.0", | |||
| "rainbow-bridge-testing": "1.0.0", | |||
| "rainbow-token-connector": "near/rainbow-token-connector#0646850267c42057e92f2d670eebe79c9c9211f9", | |||
| "rainbow-token-connector": "near/rainbow-token-connector#6855221404f81f987fcf1db9a860b2345149531a", | |||
There was a problem hiding this comment.
Why we not using d6022357e8e59ea790ff52af80df40f6036d1ec9 -- the merge of NEP-141 migration?
There was a problem hiding this comment.
atm of writing it, that PR haven't land, let's update.
| @@ -8,4 +8,4 @@ edition = "2018" | |||
| crate-type = ["cdylib", "rlib"] | |||
|
|
|||
| [dependencies] | |||
| near-sdk = "0.11.0" | |||
| near-sdk = { git = "https://github.com/near/near-sdk-rs", rev = "613adcab6322e4f830efb4d5bde2a810ae642158" } | |||
There was a problem hiding this comment.
Can you check the commit please?
There was a problem hiding this comment.
It is the right commit (the first in this PR: near/near-sdk-rs#325) It is already merged, after release we will be able to update.
mfornet
commented
Mar 12, 2021
mfornet
force-pushed
the
update_connector
branch
from
9f7833e
to
1119efb
Compare
Use commit on master.
mfornet
force-pushed
the
update_connector
branch
from
1119efb
to
edf2ea4
Compare
karim-en
pushed a commit
that referenced
this pull request
Dec 20, 2021
* fix: Don't use env::signer_account_id Instead use env::predecessor_account_id. Using signer_account_id has the same problems of using tx.origin in Ethereum. See link below for more details: ethereum/solidity#683 * fix: Use fixed near-sdk-version Need to use fixed near-sdk-version for compatibility with rainbow-token-connector. This restriction will be lifted once the special commit used by the connector lands on near-sdk-rs. * Add test to check near contracts are compiled correctly * Fix pipeline.yml syntax * Update near-sdk from eth-types * Recompile contracts * fix: Use new version of the connector. TODO: Don't use current pinned commit from token-connector, instead wait until it is merged into master * Update arguments to deploy locker using new interface * Use fixed amount of gas * Compile contracts * Update tests * Update cli/package.json Use commit on master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created to trigger CI (and integration tests) with the new version of the connector
TODO: Don't use current pinned commit from token-connector, instead wait until it is merged into master