feat: EVM locker implementation #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it is better to open separate PR for these changes, so we can include it into the post-audit review:
|
kiseln
reviewed
Oct 16, 2024
karim-en
changed the title
olga24912
requested changes
Oct 30, 2024
olga24912
requested changes
Nov 4, 2024
olga24912
approved these changes
Nov 4, 2024
kiseln
approved these changes
Nov 5, 2024
| if (fee >= amount) { | ||
| revert InvalidFee(); | ||
| } | ||
|
|
||
| address tokenAddress = nearToEthToken[token]; | ||
| uint256 extensionValue = msg.value - nativeFee; |
There was a problem hiding this comment.
Still feels like calculating value inside the extension method is more appropriate
There was a problem hiding this comment.
Nope, the difference should be calculated here for two reasons:
1- we could implement a refund later.
2- it works as a verification of msg.value >= nativeFee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EVM::initTransfer, so it now accepts the token address instead of the token ID and message instead ofnear_account_id:msg.SolAddresstype with validation.Todo in follow-up PRs: