-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use new IterableMap
and IterableSet
collections
#139
base: master
Are you sure you want to change the base?
Conversation
* Test upgrade * Add more storage changes * Reduce test binary size
@karim-en But the test says the opposite. |
Sorry it was a typo. I wanted to say "aren't backward compatible" |
I thought to add these changes to the 0.3.0 version, but as I can see, this version has already been released. |
It is dangerous to do a release like this because the plugin's users would like to upgrade to the latest version and miss the plugins being upgradable and needing a migration. |
Changing a minor version if the major is 0 implies the existence of breaking changes by semver rules. As for me, I don't like a feature flag. I would postpone these changes to the next release though. |
It is storage breaking changes, we can't allow releasing things like this without proper storage migration implementation. Check these contracts |
Also, IMHO I'm skeptical about the performance improvements of the store crate; I've checked the code, and there is a scenario where theses collections introduce an extra clone |
TODO: Check backward compatibility.