Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent interpretation of fee field in Deposited Event #29

Open
olga24912 opened this issue May 8, 2023 · 1 comment
Open

Inconsistent interpretation of fee field in Deposited Event #29

olga24912 opened this issue May 8, 2023 · 1 comment

Comments

@olga24912
Copy link
Collaborator

In current pipeline for transferring the Eth from Ethereum to Near, we initiate the transfer on Ethereum side by calling the depositToNear in EthCustodian contract (https://github.com/aurora-is-near/eth-connector/blob/master/eth-custodian/contracts/EthCustodian.sol#L86). After that the Deposited event is created. And this Deposited event contains the fee field.

According to:

We would like to transfer the amount - fee to the new_owner and the fee to the relayer. But in current realization we transfer the amount to the new_owner and nothing to relayer: https://github.com/aurora-is-near/aurora-eth-connector/blob/master/eth-connector/src/lib.rs#L563

PR with this changes: #16

I propose to add comments in all contracts that it is deprecated field and extra check that fee == 0 into EthCustodian contract.

@mrLSD
Copy link
Collaborator

mrLSD commented May 10, 2023

It's not exactly fully true, because we send that field in TransferMessage. End some other users, that can use custom Engine - can use it in their our mind.

@mrLSD mrLSD assigned mrLSD and unassigned mrLSD May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants