Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check fee==0 in deposit to near #57

Open
olga24912 opened this issue May 9, 2023 · 0 comments
Open

Add check fee==0 in deposit to near #57

olga24912 opened this issue May 9, 2023 · 0 comments

Comments

@olga24912
Copy link
Contributor

Currently, when we deposit to near the Eth we ignore the fee argument (https://github.com/aurora-is-near/aurora-eth-connector/blob/master/eth-connector/src/lib.rs#L563)

So, we should add the extra check that fee == 0 and add comment that it is deprecated argument. https://github.com/aurora-is-near/eth-connector/blob/master/eth-custodian/contracts/EthCustodian.sol#L88

More details: Near-One/aurora-eth-connector#29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@olga24912