Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure that PbxGroups are not duplicated #17

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

jcassidyav
Copy link

This tracks the PbxGroups that are created, to ensure that duplicates are not created while also allowing for the scenario as described in #15 addressing NativeScript/nativescript-cli#5765.

It tracks the groups in an external file so that you can edit the project in XCode and still maintain the link.

@cla-bot cla-bot bot added the cla: yes label Feb 19, 2024
@jcassidyav
Copy link
Author

@rigor789 I think this will satify the original issue in #15 and the reciently reported duplication issues in the project.

@rigor789
Copy link
Member

Interesting approach - we can give it a go for sure! I was also wondering if we could store this in the pbxproj itself, but I imagine XCode may clean it up if it's an unknown entry...

Interestingly we could also store it as comments above the groups I guess - but anyways these are just ideas, storing in a separate file should be totally fine too.

@jcassidyav
Copy link
Author

jcassidyav commented Feb 20, 2024

Yeah unfortunatly once you do anything, say rename a file the pbxproj gets cleaned up.

Of course editing the project in xcode is probably not that common a thing to do.

@rigor789
Copy link
Member

Ah that's unfortunate - renaming in XCode shouldn't break it, so no-go on that!

@rigor789 rigor789 merged commit 99947af into NativeScript:main Feb 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants