Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear all outletKeys instead of only the first #2304

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

karsie
Copy link

@karsie karsie commented Nov 26, 2020

PR Checklist

What is the current behavior?

Only the first outletKey of the outlet is used to destroy past views.

What is the new behavior?

All outletKeys of the outlet is used to destroy past views.

Fixes #2303.

@cla-bot
Copy link

cla-bot bot commented Nov 26, 2020

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Kars Blom.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PRO doesn't clear all outlets correctly
1 participant