Skip to content

Commit

Permalink
Removed duplicate wordings from multiple (many) files, and made simpl…
Browse files Browse the repository at this point in the history
…e fixes where possible
  • Loading branch information
just-an-engineer authored and just-an-engineer committed Jul 20, 2024
1 parent e7dc264 commit 4167ac8
Show file tree
Hide file tree
Showing 426 changed files with 527 additions and 527 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -855,7 +855,7 @@ <H1 align="center">Ghidra 10.3 Change History (May 2023)</H1>
<li><I>CParser</I>. Enum constants are now created by the CParser when <span class="gcode">#define</span> expressions ending in <span class="gcode">ULL</span>, <span class="gcode">LLU</span>, <span class="gcode">LL</span>, and <span class="gcode">LU</span> are found in parentheses. (GP-3285, Issue #5161)</li>
<li><I>CParser</I>. Fixed expansion of <span class="gcode">#define</span> statements embedded in <span class="gcode">#include</span> files and parsing of constants with <span class="gcode">UL</span>/<span class="gcode">LL</span> size specifications. (GP-3310, Issue #5207)</li>
<li><I>CParser</I>. Fixed CParser issues with forward-declared Enums and typedefs used within the body of functions. (GP-3371, Issue #3526, #5271)</li>
<li><I>CParser</I>. <span class="gcode">Enum</span> sizes are now set to the size of an <span class="gcode">int</span> for the processor (formerly 4), and <span class="gcode">enum</span>s from <span class="gcode">#define</span>s are set to the the smallest <span class="gcode">enum</span> size that will fit the number (formerly 8). Future change will add packed <span class="gcode">enum</span> sizes. (GP-3385)</li>
<li><I>CParser</I>. <span class="gcode">Enum</span> sizes are now set to the size of an <span class="gcode">int</span> for the processor (formerly 4), and <span class="gcode">enum</span>s from <span class="gcode">#define</span>s are set to the smallest <span class="gcode">enum</span> size that will fit the number (formerly 8). Future change will add packed <span class="gcode">enum</span> sizes. (GP-3385)</li>
<li><I>Data</I>. Corrected handling of zero-length components in the form of Listing DataComponent CodeUnits. These were incorrectly reporting a length of 0 instead 1; all Listing Data, including DataComponents, must report a positive non-zero length. (GP-3314)</li>
<li><I>Data Types</I>. Automatically created class structures now respect the <span class="gtitle">Preferred Root Namespace Category</span> property. (GP-1123, Issue #3196)</li>
<li><I>Data Types</I>. Added support for floating-point data types to parse decimal string representation. A significant refactor of FloatFormat and BigFloat was completed. BigFloat is now used as the value class for all float data types. Introduced <span class="gcode">DataType.getAlignedLength()</span> method which was needed to differentiate between the <em>raw</em> encoding size and the <em>aligned</em> (i.e., padded) size used by a compiler when allocating storage (i.e., <span class="gcode">sizeof</span>). Example: for x86-32 gcc, 80-bit float has an aligned-length of 12-bytes which reflects compiler's <span class="gcode">sizeof(long double)</span>. (GP-1379)</li>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
* <li>Observations of registers behave exactly the same as observations for memory, by leveraging
* Ghidra's "register space." The only difference is that those observations must be recorded with
* respect to a given thread. Each thread is effectively allocated its own copy of the register
* space. Most the the API components require you to obtain a special "register space" for a given
* space. Most of the API components require you to obtain a special "register space" for a given
* thread before recording observations of or applying annotations to that thread.</li>
* </ul>
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
* <li>Observations of registers behave exactly the same as observations for memory, by leveraging
* Ghidra's "register space." The only difference is that those observations must be recorded with
* respect to a given thread. Each thread is effectively allocated its own copy of the register
* space. Most the the API components require you to obtain a special "register space" for a given
* space. Most of the API components require you to obtain a special "register space" for a given
* thread before recording observations of or applying annotations to that thread.</li>
* </ul>
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public GdbThreadGroupStartedEvent(CharSequence tail) throws GdbParseError {
}

/**
* Get the the process ID
* Get the process ID
*
* @return the process ID
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -969,7 +969,7 @@ protected synchronized void processEvent(GdbEvent<?> evt) {
return;
}
/**
* NOTE: I've forgotten why, but the the state update needs to happen between handle and
* NOTE: I've forgotten why, but the state update needs to happen between handle and
* finish.
*/
boolean cmdFinished = false;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ static Map<String, LocationTrackingSpec> allSuggested(PluginTool tool) {
List<LocationTrackingSpec> getSuggested(PluginTool tool);

/**
* Attempt to parse the given configuration name as as specification
* Attempt to parse the given configuration name as specification
*
* @param name the configuration name, usually including a prefix unique to each factory
* @return the specification, or null if this factory cannot parse it
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,7 @@ public static State sameAddress(Collection<State> col) {
}

/**
* Get the desired state were the the logical breakpoint to be toggled
* Get the desired state were the logical breakpoint to be toggled
*
* <p>
* The expected "action" when toggling a breakpoint may vary depending on whether or not the
Expand Down
2 changes: 1 addition & 1 deletion Ghidra/Debug/Debugger-rmi-trace/DEVNOTES.txt
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ I instead just use a fixed 32-bit int now.

# How-To?

For now, I'd say just the the gdb implementation as a template / guide.
For now, I'd say just the gdb implementation as a template / guide.
Just beware, the whole thing is a bit unstable, so the code may change, but still, I don't expect it to change so drastically that integration work would be scrapped.

If you're writing Python, create a Python package following the template for gdb's.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ def put_registers(self, space, values, snap=None):
"""
TODO
values is a dictionary, where each key is a a register name, and the
values is a dictionary, where each key is a register name, and the
value is a byte array. No matter the target architecture, the value is
given in big-endian byte order.
"""
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ protected void run() throws Exception {
return;
}
println("Stack depth at " + currentAddress + ": " + info.depth());
println("Return address address: " + addressToString(info.ofReturn()));
println("Return address: " + addressToString(info.ofReturn()));
println("Saved registers:");
for (Entry<Register, Address> entry : info.saved().entrySet()) {
println(" " + entry);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
* <li>Observations of registers behave exactly the same as observations for memory, by leveraging
* Ghidra's "register space." The only difference is that those observations must be recorded with
* respect to a given thread. Each thread is effectively allocated its own copy of the register
* space. Most the the API components require you to obtain a special "register space" for a given
* space. Most of the API components require you to obtain a special "register space" for a given
* thread before recording observations of or applying annotations to that thread.</li>
* </ul>
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ public long getRowCount(Class<? extends ActionContext> ctxCls) {
* For testing: to verify the contents of a message delivered to the console log
*
* @param ctx the context
* @return the the log entry
* @return the log entry
*/
public LogRow<?> getLogRow(ActionContext ctx) {
return provider.getLogRow(ctx);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ public String toString() {
/**
* Render the key for display in diagnostics
*
* @return the the key as a string
* @return the key as a string
*/
default String keyToSimpleString() {
return key().toString();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ public void testAutoDisasembleReDisasembleX8664Offcut() throws Throwable {
assertMnemonic("JMP", instructions.getAt(0, tb.addr(0x00400000)));
/**
* Depending on preference for branch or fall-through, the disassembler may or may not
* proceed to the following instructions. I don't really care, since the test is the the
* proceed to the following instructions. I don't really care, since the test is the
* JMP gets deleted after the update to PC.
*/
});
Expand Down Expand Up @@ -328,7 +328,7 @@ public void testAutoDisassembleReDisassembleX8664OffcutByEmulation() throws Thro
assertMnemonic("JMP", instructions.getAt(0, tb.addr(0x00400000)));
/**
* Depending on preference for branch or fall-through, the disassembler may or may not
* proceed to the following instructions. I don't really care, since the test is the the
* proceed to the following instructions. I don't really care, since the test is the
* JMP gets deleted after the update to PC.
*/
});
Expand Down Expand Up @@ -377,7 +377,7 @@ public void testAutoDisassembleReDisassembleX8664OffcutByProgEmu() throws Throwa
assertMnemonic("JMP", instructions.getAt(0, tb.addr(0x00400000)));
/**
* Depending on preference for branch or fall-through, the disassembler may or may not
* proceed to the following instructions. I don't really care, since the test is the the
* proceed to the following instructions. I don't really care, since the test is the
* JMP gets deleted after the update to PC.
*/
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ public synchronized boolean isBusy() {
}

/**
* Check the the value is available immediately
* Check the value is available immediately
*
* @return true if {@link #request()} or {@link #provide()} has been called and completed.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public AsyncPairingCache(int maxPending) {
protected abstract Map<K, CompletableFuture<V>> createPromiseCache(int max);

/**
* Enter a promise for the the given key into the cache
* Enter a promise for the given key into the cache
*
* <p>
* If the result for the given key is already available, the promise does not enter the cache.
Expand All @@ -83,7 +83,7 @@ public CompletableFuture<V> waitOn(K key) {
}

/**
* Enter a promise for the the given key into the cache
* Enter a promise for the given key into the cache
*
* <p>
* If the result for the given key is already available, the promise does not enter the cache.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@
* more succinct syntax.
*
* <p>
* Finally, notice the call to to {@link AsyncSequenceHandlerForRunner#exit(Object)} passing the
* Finally, notice the call to {@link AsyncSequenceHandlerForRunner#exit(Object)} passing the
* final result of the sequence. Requiring this is a bit of a nuisance, but it makes clear what the
* result of the sequence is. Furthermore, {@code exit} can be called by any action, not just the
* final one. In the composition pattern, execution cannot be truncated except by error handling. In
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public class XmlTargetObjectSchemaTest {
<element schema="OBJECT" />
<attribute schema="VOID" fixed="yes" hidden="yes" />
</schema>
</context>"""; // Cannot have final final new-line or serialize test will fail
</context>"""; // Cannot have final new-line or serialize test will fail

protected static final DefaultSchemaContext CTX = new DefaultSchemaContext();
protected static final SchemaName NAME_ROOT = new SchemaName("root");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1498,12 +1498,12 @@ public void updateMemoryDeleteRegionBlock(TraceMemoryRegion region) {
}

public void updateMemoryAddSpaceBlock(AddressSpace space) {
// Spaces not not time-bound. No visibility check.
// Spaces not time-bound. No visibility check.
memory.updateAddSpaceBlock(space);
}

public void updateMemoryDeleteSpaceBlock(AddressSpace space) {
// Spaces not not time-bound. No visibility check.
// Spaces not time-bound. No visibility check.
memory.updateDeleteSpaceBlock(space);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
import ghidra.dbg.util.PathUtils.PathComparator;

/**
* An immutable path of keys leading from one object object to another
* An immutable path of keys leading from one object to another
*
* <p>
* Often, the source is the root. These are often taken as a parameter when searching for values. In
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -577,7 +577,7 @@ public DBTraceInstruction addInstruction(long snap, Address start, TracePlatform
*
* @param snap the starting snap
* @param start the min address
* @param platform the platform the the language to disassemble
* @param platform the platform the language to disassemble
* @param buf the bytes to place, which will become the unit's bytes
* @return the instruction unit
* @throws CodeUnitInsertionException if the instruction cannot be created
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ public Iterator<T> iterator() {
* Iterate over the entries as ordered by the index
*
* <p>
* Each entry is a key-value value where the "key" is the value of the indexed field, and the
* Each entry is a key-value entry where the "key" is the value of the indexed field, and the
* "value" is the object.
*
* @return the iterator
Expand Down Expand Up @@ -426,7 +426,7 @@ public K lowerKey(K key) {
* @param key the key
* @see #descending()
* @see #sub(Object, boolean, Object, boolean)
* @return the the value of the previous key, or null
* @return the value of the previous key, or null
*/
public T lowerValue(K key) {
return firstOf(head(key, false).descending().values());
Expand Down
2 changes: 1 addition & 1 deletion Ghidra/Extensions/SleighDevTools/pcodetest/c_src/builtin.c
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ static void ftoa(float f, char *buff, int len)
fa = f2;
// printf("%f = %u 2^%d 10^%d?\n", f, fa, e2, ea);
while (e2 > 0) {
// If the the high bit is set
// If the high bit is set
// then we can't multiply by 2
// without losing it, so divide by 10
// and round off
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ <H2 class="title" style="clear: both"><A name="IngestOverview"></A>Ingest
"filename">localhost</CODE> is running both a Ghidra Server and a BSim PostgreSQL database
server. On the Ghidra Server, a repository named <CODE class="filename">repo</CODE> has
been created. On the BSim server, a database named <CODE class="filename">repo</CODE> has
also been created. See See <A class="xref" href=
also been created. See <A class="xref" href=
"CommandLineReference.html#BSimCommand">Command-Line Utility Reference</A> for more
details on use of <STRONG>bsim</STRONG> command and other supported BSim databases.</P>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,7 @@ protected List<FunctionPair> pairFunctions(LSHVectorFactory vectorFactory,
* to create symmetric score contributions and accumulate the contributions in the matrix
* @param pairs is the full list of pairs in the cluster
* @param i is the first function pair sharing this pair of executables
* @param j is the the last(+1) function pair sharing this pair of executables
* @param j is the last(+1) function pair sharing this pair of executables
*/
private void scoreAcrossExecutablePair(List<FunctionPair> pairs, int i, int j) {
int size = j - i;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
import java.io.Writer;

/**
* A user-defined category associated associated with an executable
* A user-defined category associated with an executable
* Specified by a -type- and then the particular -category- (within the type) that
* the executable belongs to.
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
// Reports the the number of disassembly error bookmarks currently in the program.
// Reports the number of disassembly error bookmarks currently in the program.
// This can be an "indicator" of bad analysis, strange instructions, or non-returning functions.
//
// Assumes a program is open.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ <H2><A name="Navigation"></A>Navigation</H2>


<A name="Show_Xrefs"></A>
<P>In the XRef field, sometimes there are too many addresses to display so the the field will
<P>In the XRef field, sometimes there are too many addresses to display so the field will
display "[more]" to indicate that one or more cross-reference addresses are not shown.</P>

<BLOCKQUOTE>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -851,7 +851,7 @@ <H3><A name="Operands_Field"></A>Operands Field</H3>
contains the prefix to use for local labels.</P>

<P><B>Enable Word Wrapping -</B> Option to wrap strings in operand lines that are too long
to fit in the operand field. Note that that word wrapping can only occur where spaces exist
to fit in the operand field. Note that word wrapping can only occur where spaces exist
in the string.<BR>
</P>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ <H2><A name="Structure_Editor_Bitfields"></A>Bitfield Component</H2>
must be used to precisely place a bitfield component. Adding a bitfield component via the
structure table view via datatype text entry (e.g., char:1) provides only rough placement for non-packed
structures since additional bytes will be introduced.
The BitField Editor may be displayed using the the Add Bitfield and
The BitField Editor may be displayed using the Add Bitfield and
Edit Bitfield popup menu actions on a selected structure component. The datatype text entry approach
must be used for all unions and packed structures.</li>
</ul>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1118,7 +1118,7 @@ <H3><A name="Pointer_Typedef_Settings"></A>Pointer-Typedef Settings</H3>
<BLOCKQUOTE>
<P>On occasion there may be the need to add stipulate additional attributes on a pointer
type to stipulate how the associated pointer should be interpreted or processed during analysis.
Such pointer attributes may only be specified when such a pointer in in the form of a Typedef
Such pointer attributes may only be specified when such a pointer in the form of a Typedef
which enables the datatype to preserve these attributes during type resolution and propagation.
This includes preservation of such Typedef Settings within a data type archive, and through
merge processing, which normal Data Settings do not support.</P>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ <H2><A name="ProgramRootNode"></A>The Data Type Tree<BR>
</TD>

<TD style="vertical-align: top;">- Indicates the archive has datatypes from a
source archive that has been been modified. An update is needed.</TD>
source archive that has been modified. An update is needed.</TD>
</TR>

<TR valign="top">
Expand Down Expand Up @@ -525,7 +525,7 @@ <H2>Miscellaneous Actions</H2>
<H3><A name="Copy"></A>Copy</H3>

<BLOCKQUOTE>
<P>The <I><B>Copy</B></I> action can be be used to
<P>The <I><B>Copy</B></I> action can be used to
<A href="data_type_manager_description.htm#CopyDataType">copy
selected data types</A> and/or
<A href="data_type_manager_description.htm#CopyCategory">copy selected categories</A>.
Expand All @@ -539,7 +539,7 @@ <H3><A name="Copy"></A>Copy</H3>
<H3><A name="Cut"></A>Cut</H3>

<BLOCKQUOTE>
<P>The <I><B>Cut</B></I> action can be be used to
<P>The <I><B>Cut</B></I> action can be used to
<A href="data_type_manager_description.htm#MoveDataType">move selected
data types</A> and/or
<A href="data_type_manager_description.htm#MoveCategory">move selected categories</A>. The
Expand Down
Loading

0 comments on commit 4167ac8

Please sign in to comment.