Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ONT update #321

Merged
merged 249 commits into from
May 2, 2024
Merged

Conversation

kedhammar
Copy link

@kedhammar kedhammar commented Apr 16, 2024

Summary of changes:

  • Introduce new module calc_from_args in which generalized calculations can be performed without hardcoding the names of the steps, fields and file slots that are used. This can instead be customized in the LIMS config as script arguments.
  • Add ONT barcodes to data dir for cross-referencing LIMS reagent labels
  • epp.py functions to traceback target artifact using API acrobatics
  • Introduced function get_ont_library_contents for breaking down ONT sequencing libraries into their components and returning a master dataframe
  • Derive Anglerfish and MinKNOW samplesheets from aforementioned dataframe
  • Dump aforementioned dataframe in StatusDB nanopore_runs database

General improvements:

  • Typing annotation
  • Harmonize variable names
  • Use 'fail-with-grace' wrapper for several scripts so you always get a log
  • Renamed some functions

# Instantiate list to collect dataframe rows
rows = []

# Remaining possibilities:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this referring to the comments showing the shrinking list of possibilities or something else?

@kedhammar kedhammar requested a review from alneberg April 24, 2024 09:44
scripts/ont_sync_to_db.py Outdated Show resolved Hide resolved
scripts/ont_sync_to_db.py Outdated Show resolved Hide resolved
scripts/ont_sync_to_db.py Outdated Show resolved Hide resolved
scripts/ont_sync_to_db.py Outdated Show resolved Hide resolved
scripts/ont_sync_to_db.py Outdated Show resolved Hide resolved
Copy link
Member

@alneberg alneberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOW!

@kedhammar kedhammar merged commit 684aa5d into NationalGenomicsInfrastructure:master May 2, 2024
7 checks passed
@kedhammar kedhammar deleted the ont-new branch May 2, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants