Implement automated linting via GitHub Actions and Pre-Commit #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ccad796.
… (prevents PEP violation). Remove redundant and non-complete "install_requires" statement.
|
During sporadic testing of this PR w. Python 3.10 on Stage, it was apparent some Pandas code become outdated and had to be updated. |
Suggested review (simplified)New files
Manually changed files
Manual commits |
alneberg
reviewed
Dec 20, 2023
alneberg
reviewed
Dec 20, 2023
alneberg
reviewed
Dec 20, 2023
kedhammar
added a commit
that referenced
this pull request
Jan 4, 2024
Fix issues appearing after deploment of PR #293
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big PR containing both the implementation of automated linting as well a fixes across the entire repo to ensure we kick things off from a place of passing all checks.
The fixes are largely non-invasive and superficial, so hopefully a thorough review and some rudimentary testing will be sufficient to accept the PR, but I'm not sure yet.
The commit history is very messy as I've been doing a lot of testing 😆