Add ComputedOption to update config at command runtime #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add EmitDefaults to jsonpb.Marshaler
fix: support qualified go imports
fix: methodTemplate use qualified go ident as method input
… enum to prevent duplicates
fix: use a global enum registry to keep infos about already generated enum to prevent duplicates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi :)
I added the
WithComputedOptionto update configuration just before running the gRPC request.It allows to use external configuration flags.
On a CLI managing multiple environments it's easier to set
--env=prodthan--server-addr=my-prod.endpoint: 8080. But using--env=prodthe command needs to do more computation, and at runtime. That's why I added this feature.I hope you'll find it useful :)