Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename little-yso test vocabulary to simply YSO and reconfigure it #1550

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

osma
Copy link
Member

@osma osma commented Nov 14, 2023

Reasons for creating this PR

The "Little YSO" test vocabulary was created in #1516 / PR #1531. But the filename little-yso.ttl and especially the vocabulary ID test-with-little-yso are a bit clumsy to work with. In addition, the test configuration for the vocabulary was quite different from what is normally used for YSO.

This PR renames little-yso.ttl to yso.ttl, changes the vocabulary ID to yso and makes the vocabulary configuration better suitable for YSO.

Link to relevant issue(s), if any

Description of the changes in this PR

  • rename little-yso.ttl to yso.ttl
  • rewrite configuration for the small YSO test vocabulary, also changing its vocabulary ID to yso
  • modify ModelTest.getLanguages to account for new vocabulary languages (fi, sv, se) introduced by the above configuration change

Known problems or uncertainties in this PR

n/a

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@osma osma added this to the 3.0 milestone Nov 14, 2023
@osma osma self-assigned this Nov 14, 2023
@osma osma requested a review from miguelvaara November 14, 2023 15:56
@osma osma force-pushed the rename-little-yso branch from 7fd547d to 254ab6a Compare November 15, 2023 07:53
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (02a5963) 70.51% compared to head (254ab6a) 70.51%.
Report is 3 commits behind head on skosmos-3.

Additional details and impacted files
@@             Coverage Diff              @@
##             skosmos-3    #1550   +/-   ##
============================================
  Coverage        70.51%   70.51%           
  Complexity        1643     1643           
============================================
  Files               32       32           
  Lines             4314     4314           
============================================
  Hits              3042     3042           
  Misses            1272     1272           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@miguelvaara miguelvaara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good! 👍

@osma osma merged commit b4e41b4 into skosmos-3 Nov 15, 2023
@osma osma deleted the rename-little-yso branch November 15, 2023 08:08
@osma osma modified the milestones: 3.x, 3.0 Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done (verified in test.dev.finto.fi, set Milestone 3.0 for both issue & PR)
Development

Successfully merging this pull request may close these issues.

2 participants