Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: service_name needs to be a string not an atom #17

Merged
merged 1 commit into from
May 17, 2024

Conversation

puzza007
Copy link
Member

Because otherwise this happens

** (FunctionClauseError) no function clause matching in IO.chardata_to_string/1

    The following arguments were given to IO.chardata_to_string/1:

        # 1
        :integrations

    Attempted function clauses (showing 2 out of 2):

        def chardata_to_string(string) when is_binary(string)
        def chardata_to_string(list) when is_list(list)

    (elixir 1.14.5) lib/io.ex:670: IO.chardata_to_string/1
    (elixir 1.14.5) lib/path.ex:558: Path.do_join/3
    (elixir 1.14.5) lib/path.ex:550: Path.join/2
    lib/mix/tasks/deploy.ex:202: Mix.Tasks.Deploy.parse_args/1
    lib/mix/tasks/deploy.ex:232: Mix.Tasks.Deploy.Init.run/1
    (mix 1.14.5) lib/mix/task.ex:421: anonymous fn/3 in Mix.Task.run_task/4
    (mix 1.14.5) lib/mix/cli.ex:84: Mix.CLI.run_task/2

Because otherwise this happens

** (FunctionClauseError) no function clause matching in IO.chardata_to_string/1

    The following arguments were given to IO.chardata_to_string/1:

        # 1
        :integrations

    Attempted function clauses (showing 2 out of 2):

        def chardata_to_string(string) when is_binary(string)
        def chardata_to_string(list) when is_list(list)

    (elixir 1.14.5) lib/io.ex:670: IO.chardata_to_string/1
    (elixir 1.14.5) lib/path.ex:558: Path.do_join/3
    (elixir 1.14.5) lib/path.ex:550: Path.join/2
    lib/mix/tasks/deploy.ex:202: Mix.Tasks.Deploy.parse_args/1
    lib/mix/tasks/deploy.ex:232: Mix.Tasks.Deploy.Init.run/1
    (mix 1.14.5) lib/mix/task.ex:421: anonymous fn/3 in Mix.Task.run_task/4
    (mix 1.14.5) lib/mix/cli.ex:84: Mix.CLI.run_task/2
@puzza007 puzza007 merged commit 6a9ce82 into master May 17, 2024
8 checks passed
@puzza007 puzza007 deleted the fix/service-name-should-be-a-string branch May 17, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant