fix: don't replace underscores in service_name with hyphens #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narrative-donc
approved these changes
Apr 5, 2024
puzza007
force-pushed
the
fix/dont-replace-underscores-in-service-name-with-hyphens
branch
2 times, most recently
from
b282f63 to
6a22e69
Compare
See NarrativeApp/CoreGateway#662 References EPD-196
GH actions and Elixir/Erlang/Ubuntu
puzza007
force-pushed
the
fix/dont-replace-underscores-in-service-name-with-hyphens
branch
from
6a22e69 to
f9941ef
Compare
puzza007
deleted the
fix/dont-replace-underscores-in-service-name-with-hyphens
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/NarrativeApp/CoreGateway/pull/662