Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ollama install and make miniforge install robust #68

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix ollama install and make miniforge install robust #68

wants to merge 2 commits into from

Conversation

moarshy
Copy link
Contributor

@moarshy moarshy commented Nov 28, 2024

  • fix darwin_install_ollama
  • fix darwin_install_miniforge

@enricorotundo
Copy link
Collaborator

hey @moarshy is this PR still valid? would you have time to fix the conflicts? let me know if I can help :)

@moarshy
Copy link
Contributor Author

moarshy commented Feb 12, 2025 •
edited
Loading

hey @moarshy is this PR still valid? would you have time to fix the conflicts? let me know if I can help :)

we might have to start a fresh one. We have reworked ollama. Are there anything you think worth looking at?

@enricorotundo
Copy link
Collaborator

Are there anything you think worth looking at?

Probably these two things:

  1. The Darwin install should work on a macOS headless system (like GH Actions). For instance, the macOS GH actions worker wasn't able to open Ollama prior to this commit.
  2. Fix hardcode ollama version in darwin_install_ollama #200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moarshy @enricorotundo