Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复send_poke无法使用 #677

Closed
wants to merge 1 commit into from
Closed

Conversation

Shua-github
Copy link
Contributor

@Shua-github Shua-github commented Dec 31, 2024

Summary by Sourcery

Bug 修复:

  • 修正 GroupPoke 函数调用中的参数顺序,以修复 send_poke 功能。
Original summary in English

Summary by Sourcery

Bug Fixes:

  • Correct the parameter order in the GroupPoke function call to fix the send_poke functionality.

Copy link

sourcery-ai bot commented Dec 31, 2024

审阅者指南 by Sourcery

这个拉取请求修复了 SendPoke 类中 GroupPoke 方法调用的参数顺序,确保正确传递组和用户标识的参数。

修复后的 SendPoke 群组操作序列图

sequenceDiagram
    participant Client
    participant SendPoke
    participant PacketApi
    participant Group

    Client->>SendPoke: send_poke(group_id, user_id)
    SendPoke->>PacketApi: GroupPoke(user_id, group_id)
    Note right of PacketApi: Fixed parameter order
    PacketApi->>Group: Send poke to user
Loading

显示 SendPoke 实现的类图

classDiagram
    class SendPoke {
        +_handle(payload: Payload)
    }
    class Payload {
        +group_id: number
        +user_id: number
    }
    SendPoke ..> Payload
    note for SendPoke "Fixed GroupPoke parameter order"
Loading

文件级别变更

变更 详情 文件
修复 GroupPoke 方法调用中的参数顺序。
  • 将 GroupPoke 方法调用中的参数顺序从 (group_id, user_id) 交换为 (user_id, group_id)。
src/onebot/action/packet/SendPoke.ts

可能关联的问题


提示和命令

与 Sourcery 交互

  • 触发新的审阅: 在拉取请求中评论 @sourcery-ai review
  • 继续讨论: 直接回复 Sourcery 的审阅评论。
  • 从审阅评论生成 GitHub 问题: 通过回复审阅评论要求 Sourcery 创建问题。
  • 生成拉取请求标题: 在拉取请求标题的任何位置写 @sourcery-ai 以随时生成标题。
  • 生成拉取请求摘要: 在拉取请求正文的任何位置写 @sourcery-ai summary 以随时生成 PR 摘要。您还可以使用此命令指定摘要应插入的位置。

自定义您的体验

访问您的仪表板以:

  • 启用或禁用审阅功能,如 Sourcery 生成的拉取请求摘要、审阅者指南等。
  • 更改审阅语言。
  • 添加、删除或编辑自定义审阅说明。
  • 调整其他审阅设置。

获取帮助

Original review guide in English

Reviewer's Guide by Sourcery

This pull request fixes the argument order in the GroupPoke method call within the SendPoke class, ensuring the correct parameters are passed for group and user identification.

Sequence diagram for the fixed SendPoke operation in groups

sequenceDiagram
    participant Client
    participant SendPoke
    participant PacketApi
    participant Group

    Client->>SendPoke: send_poke(group_id, user_id)
    SendPoke->>PacketApi: GroupPoke(user_id, group_id)
    Note right of PacketApi: Fixed parameter order
    PacketApi->>Group: Send poke to user
Loading

Class diagram showing SendPoke implementation

classDiagram
    class SendPoke {
        +_handle(payload: Payload)
    }
    class Payload {
        +group_id: number
        +user_id: number
    }
    SendPoke ..> Payload
    note for SendPoke "Fixed GroupPoke parameter order"
Loading

File-Level Changes

Change Details Files
Fixed the argument order in the GroupPoke method call.
  • Swapped the order of arguments in the GroupPoke method call from (group_id, user_id) to (user_id, group_id).
src/onebot/action/packet/SendPoke.ts

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shua-github - 我已经审查了你的更改 - 以下是一些反馈:

整体评论

  • 考虑使用英语作为PR标题,以保持代码库文档的一致性
以下是我在审查期间查看的内容
  • 🟢 一般性问题:一切看起来都很好
  • 🟢 安全性:一切看起来都很好
  • 🟢 测试:一切看起来都很好
  • 🟢 复杂性:一切看起来都很好
  • 🟢 文档:一切看起来都很好

Sourcery 对开源项目是免费的 - 如果你喜欢我们的评论,请考虑分享它们 ✨
帮助我变得更有用!请在每条评论上点击 👍 或 👎,我将使用这些反馈来改进你的评论。
Original comment in English

Hey @Shua-github - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using English for PR titles to maintain consistency in the codebase documentation
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@pk5ls20
Copy link
Collaborator

pk5ls20 commented Dec 31, 2024

我修一下

@pk5ls20 pk5ls20 closed this Dec 31, 2024
pk5ls20 added a commit that referenced this pull request Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants