Disable verifying token issued-at timestamp #224
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PyJWT v2.8.0 verifies `iat` (issued-at timestamp) by default. There are several discussions on disabling this check, since it is not within spec. [Cognito's token verification guide](https://docs.aws.amazon.com/cognito/latest/developerguide/amazon-cognito-user-pools-using-tokens-verifying-a-jwt.html#amazon-cognito-user-pools-using-tokens-manually-inspect) does not suggest verifying `iat`, unlike `exp`. Other discussions: jpadilla/pyjwt#814 jpadilla/pyjwt#939
|
Partial trace from pycognito when |
|
@pvizeli bump on this PR. WDYT? |
ludeeus
requested changes
May 13, 2024
| @@ -260,6 +260,7 @@ def verify_token(self, token, id_name, token_use): | |||
| issuer=self.user_pool_url, | |||
| options={ | |||
| "require": required_claims, | |||
| "verify_iat": False, | |||
There was a problem hiding this comment.
This one makes sense as the range was not validated before.
However, disabling this will also disable the check to see if it is an integer. That part should still be verified.
There was a problem hiding this comment.
Made an alternative with that here #252
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyJWT v2.8.0 verifies
iat(issued-at timestamp) by default. There are several discussions on disabling this check, since it is not within spec. Cognito's token verification guide does not suggest verifyingiat, unlikeexp. This should not be default behavior.Other discussions:
jpadilla/pyjwt#814
jpadilla/pyjwt#939