Use a precompiled header in dxvk and d3d9 subprojects #74
+16
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preface: Shoving
dxvk_device.h
into a precompiled header is my last-ditch effort to get Visual Studio's intellisense working properly. I do not expect this PR to be merged as-is, if at all. These are just my observations since I figured it'd be worth investigating and maybe worth some input.Pros:
build_dxvk_all_ninja.ps1
are reduced from 11 minutes to roughly 4 minutes (local machine).Cons:
rtx_ngx_wrapper.cpp
are one example of this.dxvk_device.h
and dependent headers are amplified. It's now part of ~200 translation units, up from ~100.It seems like a combination of transitive USD includes and hundreds of macros/templates in remix cause intellisense to break down. Death by a thousand cuts with no simple fix.