CMake: Do not use CMAKE_LIBRARY_ARCHITECTURE for linux #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMAKE_LIBRARY_ARCHITECTURE is engineered for Debian-derived linux, not for other distros such as RHEL-derived, Arch, etc. To detect compilers in GetCompilerAndPlatform, use instead `CMAKE_CXX_COMPILER_ID` and `CMAKE_CXX_COMPILER`, as it is used already for the `windows` case. Note that the arm version is untested, so a double check with COMPILER_ID and just COMPILER is in place. Fixes NVIDIAGameWorks#39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMAKE_LIBRARY_ARCHITECTURE is engineered for Debian-derived linux,
not for other distros such as RHEL-derived, Arch, etc.
To detect compilers in GetCompilerAndPlatform, use instead
CMAKE_CXX_COMPILER_IDandCMAKE_CXX_COMPILER, as it is usedalready for the
windowscase.Note that the arm version is untested, so a double check with
COMPILER_ID and just COMPILER is in place.
Fixes #39