Skip to content

Commit

Permalink
Address feedbacks
Browse files Browse the repository at this point in the history
Signed-off-by: Partho Sarthi <[email protected]>
  • Loading branch information
parthosa committed Dec 30, 2024
1 parent c802031 commit 026e735
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1464,7 +1464,7 @@ trait AutoTunerConfigsProvider extends Logging {

/**
* Provides configuration settings for the Profiling Tool's AutoTuner. This object is as a concrete
* implementation of the `AutoTunerConfigsProvider` interface,
* implementation of the `AutoTunerConfigsProvider` interface.
*/
object ProfilingAutoTunerConfigsProvider extends AutoTunerConfigsProvider {
def createAutoTunerInstance(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,11 @@ class QualificationAutoTunerRunner(val appInfoProvider: QualAppSummaryInfoProvid
val (recommendations, comments) =
autoTuner.getRecommendedProperties(showOnlyUpdatedProps = filterByUpdatedPropsEnabled)
// Combine the GPU recommendations with all others.
// There are two ways we can that:
// There are two ways we can do that:
// 1- Combine them from the beginning; Or
// 2- At the end, get the union of the two properties.
// The 2nd needs more effort but it favourite because it keeps two separate lists.
// Otherwise, it is difficult to do separate them logically.
// Otherwise, it is difficult to separate them logically.
val combinedProps = autoTuner.combineSparkProperties(recommendations)
val resultRecord = TuningResult(appInfoProvider.getAppID, recommendations,
comments, Option(combinedProps))
Expand Down

0 comments on commit 026e735

Please sign in to comment.