-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Databricks Tools Notebooks for Tools v24.06.0 #381
Update Databricks Tools Notebooks for Tools v24.06.0 #381
Conversation
We can include these limitations in the readme. |
We should consider moving output info to cells after running the qualification tool. It would be nice if the first cell contains a concise summary of what the qual tool does. |
Address review feedback and included a download button to download output results as a zip along with log files. |
Hi @parthosa , can we target this pr to branch-24.06? This repo follows the same release strategy as the plugin, thx. |
ef27580
to
91ab2fc
Compare
@nvliyuan, Updated the target PR to branch-24.06. Thank you. |
3e4f2be
to
df895a3
Compare
Signed-off-by: Partho Sarthi <[email protected]>
df895a3
to
21ee03a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM, tested the notebooks on Azure Databricks.
LGTM, tested both notebooks. Thanks @parthosa! |
Thank you for the reviews. Holding it off till next minor release of tools which handles the error when CSP CLIs are not present (in this case databricks and aws) NVIDIA/spark-rapids-tools#1035
.../databricks/[RAPIDS Accelerator for Apache Spark] Qualification Tool Notebook Template.ipynb
Show resolved
Hide resolved
Based on offline discussion with @viadea:
Result |
@parthosa what related issue with respect to single log (csp cli creds) needs to be fixed first in order for that limitation to resolve? I see that NVIDIA/spark-rapids-tools#1035 is merged. |
Yes @kuhushukla, it is merged and will be available to users from next release. |
In that case, |
Signed-off-by: Partho Sarthi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Fixes #380. This PR fixes the databricks notebook for compatibility with Tools v24.06.0. Would recommend feedback by testing the changes E2E.
Changes
Qualification User Tools Notebook Template:
%pip install spark_rapids_user_tools
directly since the libraries are automatically notebook scoped and we do not need to create an additional virtual environment.Tools Version
argument to use custom tools version.rapids_4_spark_qualification_output.csv
but for user tools it should bequalification_summary.csv
.Future Maintenence:
TOOLS_VER
variable in each notebook with the new version number.Evaluation
/dbfs/<eventlog>
s3
andabfs
locations becauseaws
andaz
CLI are not available.cc: @amahussein