Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ccache in UDF examples build #345

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

GaryShen2008
Copy link
Collaborator

Install ccache in Dockerfile used to build UDF example.
Update README to explain how to use it by adding some environment variables

close #343

@GaryShen2008
Copy link
Collaborator Author

GaryShen2008 commented Jan 13, 2024

One problem may be if we need to directly explain how to enable a persistent cache folder by mounting one folder to the docker like https://github.com/NVIDIA/spark-rapids-jni/blob/branch-24.02/build/run-in-docker#L66-L70.
I just give a simple sample to enable ccache and suggest to use a mounted folder, but I don't give the full commands.
I'd like to have the review first, if it's better to use a mounted folder, I can update this PR.

Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A mounted folder would be nice, but this significantly increases the complexity of running the container unless there's a run script like we have for spark-rapids-jni. I'm OK with leaving this out for the sake of simplicity, but we might want to point to the spark-rapids-jni example for how to do this.

examples/UDF-Examples/RAPIDS-accelerated-UDFs/README.md Outdated Show resolved Hide resolved
examples/UDF-Examples/RAPIDS-accelerated-UDFs/Dockerfile Outdated Show resolved Hide resolved
@GaryShen2008 GaryShen2008 merged commit 087bbd7 into NVIDIA:branch-24.02 Jan 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants