Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine UDF guide doc #320

Merged
merged 33 commits into from
Oct 24, 2023
Merged

refine UDF guide doc #320

merged 33 commits into from
Oct 24, 2023

Conversation

nvliyuan
Copy link
Collaborator

This is to refine getting started on UDF doc.

Signed-off-by: liyuan <[email protected]>
Signed-off-by: liyuan <[email protected]>
@viadea viadea requested a review from sameerz September 21, 2023 20:33
@sameerz
Copy link
Collaborator

sameerz commented Sep 26, 2023

One suggestion - try to keep lines to 100 characters for ease of reading the source.

@nvliyuan
Copy link
Collaborator Author

One suggestion - try to keep lines to 100 characters for ease of reading the source.

updated

Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Sameer that we should strive to wrap the test around column 100. Some of these suggestions will require reformatting of the paragraph if taken verbatim.

examples/UDF-Examples/RAPIDS-accelerated-UDFs/README.md Outdated Show resolved Hide resolved
examples/UDF-Examples/RAPIDS-accelerated-UDFs/README.md Outdated Show resolved Hide resolved
examples/UDF-Examples/RAPIDS-accelerated-UDFs/README.md Outdated Show resolved Hide resolved
examples/UDF-Examples/RAPIDS-accelerated-UDFs/README.md Outdated Show resolved Hide resolved
examples/UDF-Examples/RAPIDS-accelerated-UDFs/README.md Outdated Show resolved Hide resolved
examples/UDF-Examples/RAPIDS-accelerated-UDFs/README.md Outdated Show resolved Hide resolved
examples/UDF-Examples/RAPIDS-accelerated-UDFs/README.md Outdated Show resolved Hide resolved
examples/UDF-Examples/RAPIDS-accelerated-UDFs/README.md Outdated Show resolved Hide resolved
examples/UDF-Examples/RAPIDS-accelerated-UDFs/README.md Outdated Show resolved Hide resolved
examples/UDF-Examples/RAPIDS-accelerated-UDFs/README.md Outdated Show resolved Hide resolved
@nvliyuan
Copy link
Collaborator Author

Agree with Sameer that we should strive to wrap the test around column 100. Some of these suggestions will require reformatting of the paragraph if taken verbatim.

sure, already reformat the file with below code style:
image

@nvliyuan nvliyuan requested a review from jlowe October 11, 2023 09:25
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NVIDIA/spark-rapids#9362 recently removed the getting started documentation, as it is replaced by the docs at https://docs.nvidia.com/spark-rapids/user-guide/latest/index.html instead. All of the links here need to point to the new location, otherwise they will be broken links when 23.10 releases.

@nvliyuan
Copy link
Collaborator Author

NVIDIA/spark-rapids#9362 recently removed the getting started documentation, as it is replaced by the docs at https://docs.nvidia.com/spark-rapids/user-guide/latest/index.html instead. All of the links here need to point to the new location, otherwise they will be broken links when 23.10 releases.

sorry for the late response, updated the links to the new urls.

@nvliyuan nvliyuan requested a review from jlowe October 23, 2023 03:34
@nvliyuan nvliyuan merged commit 202a7f4 into NVIDIA:branch-23.10 Oct 24, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants