-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code walkthrough #59
base: main
Are you sure you want to change the base?
Code walkthrough #59
Conversation
This PR includes the merge markers around line 209. Looks like a merge conflict was merged incorrectly |
deleted merge markers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can merge, once these small changes are made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left 2 comments on 2 files. Also, I think we should add something to the README about the code walkthrough. It shows up in workbench as an application, but we aren't providing any guidance on why a user might want to turn it on and visit the page.
I think we can add a section right after "Populating the Knowledge Base," maybe call it "Learn About the Code"? Where we call out the Code Walkthrough app and how to use it to learn.
For the actual code walkthrough, what's the purpose of both the HTML and the TXT version? Will users ever actually go to the TXT? Or just the HTML for the slideshow? If it's just the HTML, then I think opening the walkthrough should take you directly to the HTML slideshow, rather than having you choose between TXT and HTML.
I also think the slideshow could benefit from short introduction, so users know what they're looking at. Something like "this slideshow will walk you through files X and Y and how we built a RAG chain."
this pull request is mostly for initial tutorial content check. could add: