Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrdiff-Mini generation #676

Merged
merged 16 commits into from
Oct 1, 2024
Merged

Conversation

jleinonen
Copy link
Collaborator

Modulus Pull Request

Description

Adds the remaining parts of a CorrDiff-Mini implementation for educational, testing and baseline model purposes:

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.

Dependencies

@jleinonen jleinonen self-assigned this Sep 17, 2024
@jleinonen
Copy link
Collaborator Author

/blossom-ci

@mnabian
Copy link
Collaborator

mnabian commented Sep 26, 2024

Hey @jleinonen , the PR looks pretty good. I just need to double check a couple of your changes tomorrow morning, and I think we can merge it then.

@mnabian mnabian self-requested a review September 27, 2024 01:49
@jleinonen
Copy link
Collaborator Author

/blossom-ci

@jleinonen
Copy link
Collaborator Author

/blossom-ci

@jleinonen
Copy link
Collaborator Author

/blossom-ci

@jleinonen jleinonen merged commit c4d42ad into NVIDIA:main Oct 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants