Add support to orphaned driver pod #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Migrate from gitlab to continue discussion |
rollandf
force-pushed
the
orphaned
branch
2 times, most recently
from
de7865c to
7c72eeb
Compare
Signed-off-by: Fred Rolland <[email protected]>
|
Thanks @rollandf. I did a quick review and this looks good to me. |
adrianchiris
reviewed
Jan 7, 2024
pkg/upgrade/upgrade_state.go
Outdated
| @@ -506,12 +541,49 @@ func (m *ClusterUpgradeStateManagerImpl) ProcessDoneOrUnknownNodes( | |||
| return nil | |||
| } | |||
|
|
|||
| // podInSyncWithDS returns true if the Pod and DS have the same Controller Revision Hash, or if Pod is orphaned | |||
| func (m *ClusterUpgradeStateManagerImpl) podInSyncWithDS(ctx context.Context, nodeState *NodeUpgradeState) (bool, error) { | |||
There was a problem hiding this comment.
should we split conditions for clarity ?
e.g return: (inSync, orphaned, error)
adrianchiris
reviewed
Jan 7, 2024
pkg/upgrade/upgrade_state.go
Outdated
| @@ -43,6 +43,11 @@ type NodeUpgradeState struct { | |||
| DriverDaemonSet *appsv1.DaemonSet | |||
| } | |||
|
|
|||
| // IsOrphanedPod returns true if Pod is not associated to a DaemonSet or is not managed by a DaemonSet | |||
| func (nus *NodeUpgradeState) IsOrphanedPod() bool { | |||
| return nus.DriverDaemonSet == nil && nus.DriverPod != nil | |||
There was a problem hiding this comment.
can DriverPod ever be nil ?
pkg/upgrade/upgrade_state.go
Outdated
| @@ -43,6 +43,11 @@ type NodeUpgradeState struct { | |||
| DriverDaemonSet *appsv1.DaemonSet | |||
| } | |||
|
|
|||
| // IsOrphanedPod returns true if Pod is not associated to a DaemonSet or is not managed by a DaemonSet | |||
There was a problem hiding this comment.
is not associated to a DaemonSet or is not managed by a DaemonSet
whats the difference between associated and managed by DaemonSet ? is it the same ?
There was a problem hiding this comment.
realized i asked to change the wording originally :D
cdesiniotis
reviewed
Jan 10, 2024
There was a problem hiding this comment.
Just a few nits from me. Overall this lgtm, thanks @rollandf
- Add orphaned driver pods in the state built - Ignore not scheduled pod in the state built - Support upgrade-requested annotation to force moving to upgrade-required state With this functionality, upgrading from a DS to a new one is possible, with the following assumptions: - New DS should have Node Anti Affinity to prevent scheduling new driver pods where old still run. - The old DS should be deleted by Operator with DeletePropagationOrphan option to keep the old driver pods running until the upgrade flow replaces them. In addition, it will also be possible to only detach the pod from DaemonSet to migrate to new DaemonSet. Signed-off-by: Fred Rolland <[email protected]>
|
Thanks @cdesiniotis for the review. I fixed according to your comments |
cdesiniotis
approved these changes
Jan 10, 2024
|
mergin per 2 LGTMs ! thx for working on it @rollandf ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgrade-required state
With this functionality, upgrading from a DS to a new one
is possible, with the following assumptions:
new driver pods where old still run.
option to keep the old driver pods running until the upgrade flow
replaces them.
In addition, it will also be possible to only detach the pod from
DaemonSet to migrate to new DaemonSet.