Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump controller-runtime to v0.17.1 #12

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

killianmuldoon
Copy link
Contributor

Bump controller runtime to v0.17.0.

Release notes: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.17.0

go.mod Outdated
k8s.io/api v0.29.0
k8s.io/apimachinery v0.29.0
k8s.io/client-go v0.29.0
k8s.io/kubectl v0.29.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This is needed in order to bump network-operator to CR 0.17.0 as there are conflicting dependencies.

go.mod Show resolved Hide resolved
@killianmuldoon killianmuldoon force-pushed the pr-bump-cr-0.17.0 branch 2 times, most recently from b8a5422 to 5687a10 Compare January 22, 2024 14:00
Copy link
Collaborator

@adrianchiris adrianchiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adrianchiris
Copy link
Collaborator

@shivamerla can we merge this one ?

@killianmuldoon killianmuldoon changed the title chore: Bump controller-runtime to v0.17.0 chore: Bump controller-runtime to v0.17.1 Feb 12, 2024
@elezar
Copy link
Member

elezar commented Feb 12, 2024

/cc @ArangoGutierrez @cdesiniotis

@cdesiniotis cdesiniotis self-requested a review February 13, 2024 18:07
Copy link
Collaborator

@cdesiniotis cdesiniotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7869365824

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.492%

Totals Coverage Status
Change from base Build 7499366876: 0.0%
Covered Lines: 1048
Relevant Lines: 1426

💛 - Coveralls

@adrianchiris adrianchiris merged commit ea58a3a into NVIDIA:main Feb 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants