Merge pull request #20 from kerthcet/cleanup/quick-return

Quick return in error case

gpuallocator/allocator.go

@@ -19,7 +19,7 @@ type Allocator struct {
 	allocated DeviceSet
 }
 
-// Policy defines an interface for plugagable allocation policies to be added
+// Policy defines an interface for pluggable allocation policies to be added
 // to an Allocator.
 type Policy interface {
 	// Allocate is meant to do the heavy-lifting of implementing the actual

gpuallocator/besteffort_policy.go

@@ -46,6 +46,10 @@ func (p *bestEffortPolicy) Allocate(available []*Device, required []*Device, siz
 		return []*Device{}
 	}
 
+	if len(required) > len(available) {
+		return []*Device{}
+	}
+
 	// Find the highest scoring GPU partition with sets of of size 'size'.
 	// Don't consider partitions that don't have at least one set that contains
 	// all of the GPUs 'required' by the allocation.

gpuallocator/besteffort_test.go

@@ -110,6 +110,14 @@ func TestBestEffortAllocate(t *testing.T) {
 			4,
 			[]int{},
 		},
+		{
+			"Required too many devices than available",
+			devices,
+			[]int{1, 2, 3, 4, 5},
+			[]int{1, 2, 3, 4, 5, 6},
+			1,
+			[]int{},
+		},
 	}
 
 	RunPolicyAllocTests(t, policy, tests)